Get rid of hardcoded sleep in tracing/runtimeeventsource/nativeruntimeeventsource #72010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorBo
approved these changes
Jul 12, 2022
jakobbotsch
reviewed
Jul 12, 2022
src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs
Outdated
Show resolved
Hide resolved
aromaa
reviewed
Jul 12, 2022
src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs
Outdated
Show resolved
Hide resolved
noahfalk
approved these changes
Jul 12, 2022
src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs
Outdated
Show resolved
Hide resolved
davmason
force-pushed
the
tracing_test_timing
branch
from
c7940dd to
4cc857c
Compare
Contributor
Author
|
Fixes #70966 |
This was
linked to
issues
Jul 13, 2022
Contributor
Author
davmason
force-pushed
the
tracing_test_timing
branch
from
4cc857c to
fe59e58
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71331
This test was failing because in some runs the event would take longer than 2 seconds to get all the way through the eventing pipeline.